#5908: Cycle tag should reset after it steps out of scope(?)
----------------------------------------------------------+-----------------
          Reporter:  Simon Litchfield <si...@quo.com.au>  |         Owner:  
nobody                                      
            Status:  new                                  |     Milestone:      
                                        
         Component:  Template system                      |       Version:  SVN 
                                        
        Resolution:                                       |      Keywords:  
cycle templatetag tag counter for loop reset
             Stage:  Accepted                             |     Has_patch:  1   
                                        
        Needs_docs:  0                                    |   Needs_tests:  0   
                                        
Needs_better_patch:  0                                    |  
----------------------------------------------------------+-----------------
Comment (by akaihola):

 Replying to [comment:6 Uninen]:
 > I made a patch based on Malcolms last comment. This works for me but I'm
 not quite sure if it is fully valid solution. If someone could take a look
 and comment this, it would be appreciated.

 I see a couple of problems (looking at the code, didn't actually test it):
  * reserves the `{{ resetcycle }}` context variable; any templates which
 happen to use it will be broken
  * can't reset multiple simultaneous cycles (will forget previous reset)
  * no tests
  * no documentation

 I'll try to think about this a bit.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/5908#comment:11>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to