#10870: Aggregates with joins ignore extra filters provided by setup_joins
--------------------------------------+-------------------------------------
Reporter: fas | Owner: fas
Status: new | Milestone:
Component: ORM aggregation | Version: SVN
Resolution: | Keywords: orm, aggregation, join,
contenttypes, filter
Stage: Accepted | Has_patch: 0
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
--------------------------------------+-------------------------------------
Comment (by mtredinnick):
This patch has a couple of problems, from looking at it quickly.
1. There's a random comment on line 1436 that doesn't refer to any code.
No code immediately follows it. It's also of the "set i to i+1" variety if
it was intended to go before line 1448, so can be removed.
2. The if-test on line 1448 can be removed. The `extra` parameter is
always a list, possibly empty. So just iterate over it and if it's empty,
nothing will be done.
--
Ticket URL: <http://code.djangoproject.com/ticket/10870#comment:2>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
