#3872: Bug in SetRemoteAddrFromForwardedFor middleware
----------------------------------------+-----------------------------------
Reporter: Simon Willison | Owner: gregorth
Status: closed | Milestone:
Component: Core framework | Version: SVN
Resolution: fixed | Keywords: middleware
Stage: Ready for checkin | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
----------------------------------------+-----------------------------------
Changes (by mtredinnick):
* status: reopened => closed
* resolution: => fixed
Comment:
Your patch doesn't generalise. What if there's another such proxy in the
middle. Then you have to look at the third-last address. And so on.
There's no standards here and no way to work it out. So we do the best we
can and no better. Going to reclose this, since, as indicated by the
various changes, there are conflicting setups.
Ultimately, if what is there doesn't work for you, don't use it. If
there's some circumstance where Django won't operate with this feature
(i.e. it's not ignorable, as opposed to no useful), then that would be a
bug and a new ticket would be appropriate.
--
Ticket URL: <http://code.djangoproject.com/ticket/3872#comment:10>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
