#10188: HttpResponse does not filter CR/LF characters from headers
----------------------------------------+-----------------------------------
Reporter: bthomas | Owner: rokclimb15
Status: reopened | Milestone: 1.1
Component: HTTP handling | Version: 1.0
Resolution: | Keywords:
Stage: Ready for checkin | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
----------------------------------------+-----------------------------------
Changes (by anonymous):
* status: closed => reopened
* needs_better_patch: 0 => 1
* resolution: fixed =>
Comment:
The patch seems to be incorrect since it's not checking whether value is
iterable or not (which throws an exception).
Replacing
{{{
if '\n' in value or '\r' in value:
}}}
with
{{{
if isinstance(value, str) and ('\n' in value or '\r' in value):
}}}
works for me.
--
Ticket URL: <http://code.djangoproject.com/ticket/10188#comment:11>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
