#11810: [gis] Typo in OpenLayers Admin JS
---------------------------------+------------------------------------------
Reporter: rcoup | Owner: jbronn
Status: new | Milestone: 1.2
Component: GIS | Version: SVN
Resolution: | Keywords: admin gis osmgeoadmin
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------+------------------------------------------
Changes (by jbronn):
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => jbronn
* milestone: => 1.2
* keywords: admin => admin gis osmgeoadmin
* needs_docs: => 0
Comment:
Obviously this is a bug. Unfortunately, fixing the typo just exposes
further bugs -- ''sigh'', thanks rcoup :) . For example, if you already
have a feature and `modifiable=False`, then the following JS error occurs
(I'm using the `WorldBorders` model from the tutorial):
{{{
geodjango_mpoly.map.getControlsByClass("OpenLayers.Control.ModifyFeature")[0]
is undefined
}}}
This is because the control wasn't enabled in the first place (now that
the typo is fixed) -- thus, some more work is needed. I've attached a
patch that addresses this additional problem, but I want to think about it
a while. Some questions to ponder: do we still want to allow drawing of
new features if `modifiable=False` (which the new patch allows)? Should
this be an option on `OSMGeoAdmin` at all when there's the `editable`
[http://docs.djangoproject.com/en/dev/ref/models/fields/#editable Field
option]?
--
Ticket URL: <http://code.djangoproject.com/ticket/11810#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
