Author: lukeplant
Date: 2010-01-04 15:55:52 -0600 (Mon, 04 Jan 2010)
New Revision: 12086
Modified:
django/trunk/django/contrib/comments/templatetags/comments.py
django/trunk/docs/ref/contrib/comments/example.txt
django/trunk/docs/ref/contrib/comments/index.txt
django/trunk/docs/ref/contrib/csrf.txt
django/trunk/docs/topics/forms/formsets.txt
django/trunk/docs/topics/forms/index.txt
django/trunk/docs/topics/forms/modelforms.txt
django/trunk/tests/regressiontests/csrf_tests/tests.py
Log:
Fixed #12053 - form examples don't validate according to w3c
Thanks to skyl for the report.
Modified: django/trunk/django/contrib/comments/templatetags/comments.py
===================================================================
--- django/trunk/django/contrib/comments/templatetags/comments.py
2010-01-04 12:16:09 UTC (rev 12085)
+++ django/trunk/django/contrib/comments/templatetags/comments.py
2010-01-04 21:55:52 UTC (rev 12086)
@@ -306,7 +306,7 @@
Example::
- <form action="{% comment_form_target %}" method="POST">
+ <form action="{% comment_form_target %}" method="post">
"""
return comments.get_form_target()
Modified: django/trunk/docs/ref/contrib/comments/example.txt
===================================================================
--- django/trunk/docs/ref/contrib/comments/example.txt 2010-01-04 12:16:09 UTC
(rev 12085)
+++ django/trunk/docs/ref/contrib/comments/example.txt 2010-01-04 21:55:52 UTC
(rev 12086)
@@ -103,7 +103,7 @@
<!-- A context variable called form is created with the necessary hidden
fields, timestamps and security hashes -->
<table>
- <form action="{% comment_form_target %}" method="POST">
+ <form action="{% comment_form_target %}" method="post">
{{ form }}
<tr>
<td></td>
Modified: django/trunk/docs/ref/contrib/comments/index.txt
===================================================================
--- django/trunk/docs/ref/contrib/comments/index.txt 2010-01-04 12:16:09 UTC
(rev 12085)
+++ django/trunk/docs/ref/contrib/comments/index.txt 2010-01-04 21:55:52 UTC
(rev 12086)
@@ -218,7 +218,7 @@
A complete form might look like::
{% get_comment_form for event as form %}
- <form action="{% comment_form_target %}" method="POST">
+ <form action="{% comment_form_target %}" method="post">
{{ form }}
<tr>
<td></td>
@@ -239,7 +239,7 @@
form. This will always return the correct URL that comments should be posted
to;
you'll always want to use it like above::
- <form action="{% comment_form_target %}" method="POST">
+ <form action="{% comment_form_target %}" method="post">
Redirecting after the comment post
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Modified: django/trunk/docs/ref/contrib/csrf.txt
===================================================================
--- django/trunk/docs/ref/contrib/csrf.txt 2010-01-04 12:16:09 UTC (rev
12085)
+++ django/trunk/docs/ref/contrib/csrf.txt 2010-01-04 21:55:52 UTC (rev
12086)
@@ -49,7 +49,7 @@
2. In any template that uses a POST form, use the :ttag:`csrf_token` tag
inside
the ``<form>`` element if the form is for an internal URL, e.g.::
- <form action="" method="POST">{% csrf_token %}
+ <form action="" method="post">{% csrf_token %}
This should not be done for POST forms that target external URLs, since
that would cause the CSRF token to be leaked, leading to a
vulnerability.
Modified: django/trunk/docs/topics/forms/formsets.txt
===================================================================
--- django/trunk/docs/topics/forms/formsets.txt 2010-01-04 12:16:09 UTC (rev
12085)
+++ django/trunk/docs/topics/forms/formsets.txt 2010-01-04 21:55:52 UTC (rev
12086)
@@ -355,7 +355,7 @@
.. code-block:: html+django
- <form method="POST" action="">
+ <form method="post" action="">
{{ formset.management_form }}
<table>
{% for form in formset.forms %}
@@ -369,7 +369,7 @@
.. code-block:: html+django
- <form method="POST" action="">
+ <form method="post" action="">
<table>
{{ formset }}
</table>
Modified: django/trunk/docs/topics/forms/index.txt
===================================================================
--- django/trunk/docs/topics/forms/index.txt 2010-01-04 12:16:09 UTC (rev
12085)
+++ django/trunk/docs/topics/forms/index.txt 2010-01-04 21:55:52 UTC (rev
12086)
@@ -172,7 +172,7 @@
example, we passed our ``ContactForm`` instance to the template using the
context variable ``form``. Here's a simple example template::
- <form action="/contact/" method="POST">
+ <form action="/contact/" method="post">
{{ form.as_p }}
<input type="submit" value="Submit" />
</form>
@@ -183,7 +183,7 @@
``form.as_p`` will output the form with each form field and accompanying label
wrapped in a paragraph. Here's the output for our example template::
- <form action="/contact/" method="POST">
+ <form action="/contact/" method="post">
<p><label for="id_subject">Subject:</label>
<input id="id_subject" type="text" name="subject" maxlength="100" /></p>
<p><label for="id_message">Message:</label>
@@ -211,7 +211,7 @@
the way a form is presented using the Django template language. Extending the
above example::
- <form action="/contact/" method="POST">
+ <form action="/contact/" method="post">
<div class="fieldWrapper">
{{ form.subject.errors }}
<label for="id_subject">E-mail subject:</label>
@@ -263,7 +263,7 @@
duplicate code by looping through each field in turn using a ``{% for %}``
loop::
- <form action="/contact/" method="POST">
+ <form action="/contact/" method="post">
{% for field in form %}
<div class="fieldWrapper">
{{ field.errors }}
@@ -322,7 +322,7 @@
``visible_fields()``. Here's a modification of an earlier example that uses
these two methods::
- <form action="/contact/" method="POST">
+ <form action="/contact/" method="post">
{% for field in form.visible_fields %}
<div class="fieldWrapper">
@@ -356,7 +356,7 @@
can reduce duplication by saving the form's loop in a standalone template and
using the :ttag:`include` tag to reuse it in other templates::
- <form action="/contact/" method="POST">
+ <form action="/contact/" method="post">
{% include "form_snippet.html" %}
<p><input type="submit" value="Send message" /></p>
</form>
@@ -373,7 +373,7 @@
If the form object passed to a template has a different name within the
context, you can alias it using the :ttag:`with` tag::
- <form action="/comments/add/" method="POST">
+ <form action="/comments/add/" method="post">
{% with comment_form as form %}
{% include "form_snippet.html" %}
{% endwith %}
Modified: django/trunk/docs/topics/forms/modelforms.txt
===================================================================
--- django/trunk/docs/topics/forms/modelforms.txt 2010-01-04 12:16:09 UTC
(rev 12085)
+++ django/trunk/docs/topics/forms/modelforms.txt 2010-01-04 21:55:52 UTC
(rev 12086)
@@ -705,14 +705,14 @@
First, you can let the formset do most of the work::
- <form method="POST" action="">
+ <form method="post" action="">
{{ formset }}
</form>
Second, you can manually render the formset, but let the form deal with
itself::
- <form method="POST" action="">
+ <form method="post" action="">
{{ formset.management_form }}
{% for form in formset.forms %}
{{ form }}
@@ -725,7 +725,7 @@
Third, you can manually render each field::
- <form method="POST" action="">
+ <form method="post" action="">
{{ formset.management_form }}
{% for form in formset.forms %}
{% for field in form %}
@@ -738,7 +738,7 @@
a ``{% for %}`` loop, you'll need to render the primary key field. For example,
if you were rendering the ``name`` and ``age`` fields of a model::
- <form method="POST" action="">
+ <form method="post" action="">
{{ formset.management_form }}
{% for form in formset.forms %}
{{ form.id }}
Modified: django/trunk/tests/regressiontests/csrf_tests/tests.py
===================================================================
--- django/trunk/tests/regressiontests/csrf_tests/tests.py 2010-01-04
12:16:09 UTC (rev 12085)
+++ django/trunk/tests/regressiontests/csrf_tests/tests.py 2010-01-04
21:55:52 UTC (rev 12086)
@@ -13,7 +13,7 @@
# Response/views used for CsrfResponseMiddleware and CsrfViewMiddleware tests
def post_form_response():
resp = HttpResponse(content="""
-<html><body><form method="POST"><input type="text" /></form></body></html>
+<html><body><form method="post"><input type="text" /></form></body></html>
""", mimetype="text/html")
return resp
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
