#12812: Inheriting from comments breaks comment moderation
----------------------------------------------+-----------------------------
          Reporter:  Beetle_B                 |         Owner:  nobody          
               
            Status:  closed                   |     Milestone:                  
               
         Component:  django.contrib.comments  |       Version:  1.1             
               
        Resolution:  invalid                  |      Keywords:  comments 
inheritance moderation
             Stage:  Unreviewed               |     Has_patch:  0               
               
        Needs_docs:  0                        |   Needs_tests:  0               
               
Needs_better_patch:  0                        |  
----------------------------------------------+-----------------------------
Changes (by kmtracey):

  * status:  reopened => closed
  * resolution:  => invalid

Comment:

 I cannot recreate any problem with the proper model being used in the
 above-noted moderation signal connections by following the documented
 method pointed to above. You haven't really provided enough information to
 recreate whatever you are seeing, and at this point the problem seems
 better suited to django-users than a ticket. As near as I can tell there
 is documented way to do what you are asking to do, and in my testing it
 works. There is also a test of `comments.get_model()` returning the
 correct model in the comment tests, and that is passing.

 If you'd like to pursue this further please follow up on django-users with
 enough specifics of your models and settings to allow someone to recreate
 the issue, and also indicate how you are observing the wrong model being
 returned by `comments.get_model()`. I tested it by putting a breakpoint in
 my custom comment `app get_model()` and observing that it was hit twice
 when I entered:

 `from django.contrib.comments.moderation import moderator`

 from a manage.py shell. From the stack trace I could see it was hit once
 for each of those signal connection lines noted above.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/12812#comment:4>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to