#13085: GenericForeignKey.get_content_type fails if `object` or `id` evaluate to
False. Should use 'is not None' test.
-----------------------------------+----------------------------------------
Reporter: benreynwar | Owner: nobody
Status: new | Milestone:
Component: Contrib apps | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-----------------------------------+----------------------------------------
Changes (by russellm):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 1
* needs_docs: => 0
Comment:
Two quick points:
1) Please generate patches relative to the root of the source tree
2) Please provide a test case, not just a patch. Under what conditions
will the object be false? Ideally, this should be in the form of a
regression test integrated into Django's test suite, but if you can't work
out how to do that, a code sample will do.
Accepting because I think I can spot the problem case (getting the content
type for an unsaved object)
--
Ticket URL: <http://code.djangoproject.com/ticket/13085#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
