#13121: Backwards compatible patch for ModelForm to improve model validation.
---------------------------------------------------+------------------------
Reporter: orokusaki | Owner: nobody
Status: closed | Milestone:
Component: Database layer (models, ORM) | Version: 1.2-beta
Resolution: duplicate | Keywords:
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------------------------+------------------------
Comment (by russellm):
Replying to [comment:5 orokusaki]:
> If this is how the Django community values bug fixes, than I won't
bother from now on. I have already caught a critical bug in the model
validation before, and it was quickly fixed. I don't see what the
difference is. Is it just because this one isn't critical. It just makes
you give up a feature, so that's not important?
The difference is that this isn't a bugfix. The code is working exactly as
it was designed to work.
You happen to disagree with the design. That's fine - I'm not going to
claim that we're infallible in the design department. But, as I keep
saying, and you seem to keep ignoring - 'IF YOU DISAGREE WITH A DECISION
WE HAVE MADE, START A THREAD ON DJANGO-DEVELOPERS'.
This isn't procedural nitpicking. I'm not saying it to exercise my vocal
cords, or out of some perverse love of a rulebook. Django's contribution
guide is the result of many years experience in running an open source
project. What we have learned is that Trac is a really crappy forum for
holding design discussions. There's no guarantee that all the relevant
players are reading the comments of any given ticket -- especially a new
ticket. If you have an active discussion, Trac has really awful habit of
losing comments when two people are writing comments at the same time.
Trac discussions aren't threaded. If it turns out that there is actually
more than one ticketable issue, it's impossible to split the discussion
into relevant parts.
When I close your tickets and tell you to take it to the mailing list, I'm
not doing it to be annoying. I'm doing it because I want to you voice your
opinion somewhere where it actually has the possibility of being heard and
acted upon.
> If I owned a automotive shop, and a person brought me their manual and
said "It says that the cigarette lighter gets hot, but it's not working",
I wouldn't simply tear the page out of the manual and say "There, now it
does just what the manual says.".
True. But if a person came to me and said "this cigarette lighter doesn't
seem to be able to roast my Thanksgiving turkey", I would say "well, it's
not supposed to", and perhaps put a note in the documentation that
roasting birds wasn't an intended use of the cigarette lighter.
There is a very important difference between a bug, and something that is
working as designed.
> I'll leave this closed instead of fighting my case, but if you change
your mind and there is something I can do to help (aside from a diff or
unit test), please let me know and I will do it right away.
You mean... other than starting a discussion on django-developers? Like
I've asked you to do 4 or 5 times?
Also: I would humbly suggest that if you aim to be helpful to open source,
you should start by learning the tools of the trade. diff and unittest
aren't obscure tools, and their use isn't specific to Django. You would be
hard pressed to find a serious open source project that didn't use both in
some way. Even if you never contribute to Django ever again, you would be
well served to learn how to use them.
--
Ticket URL: <http://code.djangoproject.com/ticket/13121#comment:6>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
