#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
-------------------------------------+--------------------------------------
Reporter: ejucovy | Owner: nobody
Status: new | Milestone:
Component: Authentication | Version: 1.1
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 1 |
-------------------------------------+--------------------------------------
Comment (by lasko):
No problem ejucovy, I do however have one concern here with regards to
your patch.
Line 83:
{{{
self.confirm_login_allowed(user_cache)
}}}
This is a pretty obvious NameError waiting to happen as user_cache is
never defined and should be self.user_cache
Once this is fixed the patch looks decent. I'll start working on the tests
Replying to [comment:6 ejucovy]:
> Replying to [comment:5 lasko]:
> > I don't see anything wrong with this implementation and would be +1 to
implementing it.
> > Would allow me to get rid of my current kluge in making this
functionality work and have a standard django supported interface.
> >
> > This however still needs tests added to it. If ejucovy doesn't wish to
do this part I can probably put something together in that realm.
>
> Thanks, I'd appreciate that!
--
Ticket URL: <http://code.djangoproject.com/ticket/12103#comment:7>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
