#11358: Flatpage sitemap shows all pages, even private pages
-----------------------------------+----------------------------------------
Reporter: dburke | Owner: mlavin
Status: new | Milestone:
Component: Contrib apps | Version: 1.0
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-----------------------------------+----------------------------------------
Comment (by mtredinnick):
The code change looks fine, however I'd like a small tweak in the
documentation: rather then explaining the effect in code
(`registration_required=False`), try to do it in English (e.g. "pages
which are visible to all users, including those not logged in" or
something a little more concise). It can disrupt the reading flow to have
to switch to understanding that flatpages model has an attribute called
`registration_required` and so on.
Are there any existing sitemap tests? If so, they might need to be updated
here. If not, have a think about if there's some way to test them even a
little bit. It might be hard to do so, but shouldn't be impossible (using
test.Client to pull back a sample of the sitemap and examine the contents,
perhaps?)
--
Ticket URL: <http://code.djangoproject.com/ticket/11358#comment:6>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
