#3100: Support for arguments on intermediate tag tokens (ex. {% if arg %}{% elif
arg %}{% endif %})
---------------------------------------------------------------+------------
Reporter: Eric Van Dewoestine <[email protected]> | Owner:
adrian
Status: reopened | Milestone:
Component: Template system | Version:
SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch:
1
Needs_docs: 0 | Needs_tests:
1
Needs_better_patch: 1 |
---------------------------------------------------------------+------------
Changes (by mtredinnick):
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
Hmm... so this is two different things in one patch: (1) is allowing args
on the intermediate tag, (2) changing if tag to include elif. We might
want (1) without (2), hence our usual insistence on one feature per
ticket.
That being said, the patch looks reasonable. However, the change to the
tests to remove the unbalanced blocks test is bad. You are **removing**
tests that check for something bad happening. If this patch doesn't let
those tests still fail, the patch is broken. If it doesn't affect those
tests, they should remain. Either way, this isn't ready for checkin yet.
I'll add "needs tests" to the flags for this reason, in case somebody is
looking for test related work. It doesn't need new tests, just those
deleted "extra endblock" tests restored, please.
--
Ticket URL: <http://code.djangoproject.com/ticket/3100#comment:13>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
