#14299: Add additional cache.*_many functions
-----------------------------------+----------------------------------------
Reporter: manfre | Owner: manfre
Status: closed | Milestone: 1.3
Component: Cache system | Version: SVN
Resolution: wontfix | Keywords: cache, add_many,
offset_many
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
-----------------------------------+----------------------------------------
Changes (by jdunck):
* needs_better_patch: 0 => 1
Comment:
Feedback as I come across things -- I somehow didn't notice Jacob's
already wontfix'd this ticket. Perhaps feedback is useful anyway. I
leave Jacob to answer your previous questions.
1. Did you test against other backends? I see you've implemented in
base, but it's not clear to me that base will work in all backends.
1. Dummy .set_many should return the empty dict rather than None
1. Why the change to smart_str in memcache incr/decr? Unrelated issue?
1. Replace: "``add_many()`` returns a dictionary with all the keys passed
and their values being a bool indicating whether or not the value was
added" with "``add_many() returns a dictionary containing all keys passed
in and boolean values indicating whether the value was added."
1. test_add_many and test_offset_many are repeated in your diff. Please
remove the dupes.
1. move comment "# add_many takes a second ``timeout`` parameter" below
the call to delete_many.
1. In test_add_many, please ensure to test both cases where a key does
exist and where it does not.
1. In offset_many, I'm not sure about returning booleans for a failed
incr/decr. Is this something you've seen in other backends?
--
Ticket URL: <http://code.djangoproject.com/ticket/14299#comment:4>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
