#14354: Check password is not None in User.check_password
-------------------------------------+--------------------------------------
Reporter: berryp | Owner: laurentluce
Status: assigned | Milestone: 1.3
Component: Authentication | Version: 1.2
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
-------------------------------------+--------------------------------------
Changes (by russellm):
* needs_better_patch: 0 => 1
Comment:
Looks good, Laurent. Some minor review comments:
* As discussed on the list, the check for invalidity should allow empty
string, and use None to mark an unusable password.
* Empty setup/teardown methods aren't needed. There's no need to formally
declare a no-op.
* The tests for the createsuperuser management commands output to stdout
- tests shouldn't have any visible manifestation. As part of the migration
to use unittests, we're modifying the admin commands to take stdout/stderr
arguments, and writing output to those streams. See loaddata/dumpdata for
examples. This allows the test commands (or any other programmatic usage)
to provide a stream that will be used for output (which provides a second
way to fix this test problem -- invoke the test with verbosity=0).
* While you're in that areas, the "superuser created" text should also be
covered by a verbosity check; verbosity=0 should output nothing.
--
Ticket URL: <http://code.djangoproject.com/ticket/14354#comment:6>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
