#14467: AllValuesFilterSpec does not work with Null
-------------------------------------------+--------------------------------
Reporter: oyvind | Owner: nobody
Status: reopened | Milestone: 1.3
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: Filterspec
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Changes (by lrekucki):
* stage: Ready for checkin => Accepted
Comment:
IMHO, the TestCase needs some code style changes:
* Regression test can now use ``django.test.client.RequestFactory`` to
mock a request instead of creating it's own.
* You don't need to delete created ORM objects in tearDown() - the DB
will get flushed anyway.
* Python has comments, you don't need to put noop string expressions.
Also, looping through the list (using "in") to check if there is a None,
when we just looped feels weird.
--
Ticket URL: <http://code.djangoproject.com/ticket/14467#comment:9>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
