#14531: Add validate_unique flag to ModelForm.Meta
---------------------------------+------------------------------------------
          Reporter:  wogan       |         Owner:  wogan
            Status:  closed      |     Milestone:       
         Component:  Forms       |       Version:  1.2  
        Resolution:  wontfix     |      Keywords:       
             Stage:  Unreviewed  |     Has_patch:  1    
        Needs_docs:  1           |   Needs_tests:  1    
Needs_better_patch:  1           |  
---------------------------------+------------------------------------------
Changes (by russellm):

  * status:  new => closed
  * resolution:  => wontfix

Comment:

 I don't see how adding a new option is a fix for "user needs to read the
 documentation" -- any new option will also require documentation, and that
 documentation will need to be read and understood.

 If you override a method, you need to call super() to get the superclass'
 behavior. This is entirely consistent Python idiom. The default
 implementation of clean() validates all the uniqueness conditions for the
 model. If you implement clean(), and don't call super(), then you don't
 get that validation. I don't see the value in adding an option flag to
 implement behavior.

 If your argument is that documentation needs to be improved around the
 implications of calling super(), then I'm happy to entertain suggestions.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/14531#comment:2>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to