#10899: easier manipulation of sessions by test client
----------------------------------------+-----------------------------------
Reporter: tallfred | Owner: nobody
Status: reopened | Milestone:
Component: Testing framework | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 0
Needs_better_patch: 0 |
----------------------------------------+-----------------------------------
Comment (by russellm):
I think the patch is on the right track. The currently documented behavior
needs to continue to work for backwards compatibility purposes, but I
don't see the proposed behavior affecting that.
I have two comments on the patch:
Firstly, can the call to _session_save() be pushed further down the stack
into request()? That would removes some code duplication, and I can't see
any obvious reason why it wouldn't work the same (feel free to prove me
wrong!)
Secondly, there is some loss of cookie properties from the login method.
This needs to be checked to make sure there aren't any backwards
incompatible changes to the way the login cookie is being set during
testing.
Regarding docs -- you're correct that this new behavior is less explicit,
so explaining exactly how and when the session is persisted will be an
important thing to explain well.
--
Ticket URL: <http://code.djangoproject.com/ticket/10899#comment:9>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
