#11870: Moderation doesn't work with comments extended from
BaseCommentAbstractModel
----------------------------------------------+-----------------------------
Reporter: HM | Owner: nobody
Status: new | Milestone:
Component: django.contrib.comments | Version: SVN
Resolution: | Keywords: moderation
Stage: Accepted | Has_patch: 0
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 1 |
----------------------------------------------+-----------------------------
Comment (by thejaswi_puthraya):
Jannis, This patch works but the settings.py should have the COMMENTS_APP
attribute set before the tests are run. The toggling of the COMMENTS_APP
attribute in the CustomCommentTest class (present under
comment_tests/tests/app_api_tests.py) does not help, because syncdb
would've already taken place as soon as the test started and in the
process, the evaluation of get_model function in the CommentFlag model.
The problem of setting the COMMENTS_APP to the custom comments explicitly
before the tests are run will cause all the default comment tests to fail,
unless there are some changes made the CommentTestCase class' setUp
method.
What do you suggest? Do we require a test for this or modifying the
comment tests?
--
Ticket URL: <http://code.djangoproject.com/ticket/11870#comment:11>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
