#14370: Adding support for Autocomplete in contrib.admin
-------------------------------------------+--------------------------------
Reporter: tyrion | Owner: nobody
Status: new | Milestone:
Component: django.contrib.admin | Version: 1.2
Resolution: | Keywords: autocomplete
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Comment (by robhudson):
1. I should have caught the above code sample when trying to hook this up,
but this will need docs in the patch as part of the Django docs before
this is committed. That's what I was looking for and referring to.
2 & 3. Ignore. Apologies.
OK, so now that I have it working a few comments...
A. Looks like it could use a little CSS touch-up work. I didn't see any
CSS changes or additions on the bitbucket changes.
B. I think some reasonable defaults should be considered so not all keys
of the dict need to be specified. e.g. if `queryset` isn't specified
assume an `.all()` query?
C. Django docs.
D. Have you considered how we might test this? It would probably be
pretty easy to test that the admin hooked up the view that the
autocomplete calls. Testing the JS itself would prove a bit tougher but
jezdez and I have mentioned that we probably need to figure this out
eventually (QUnit?).
--
Ticket URL: <http://code.djangoproject.com/ticket/14370#comment:9>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
