#15144: Max age set in cache control no longer obeys timeout set with 
@cache_page
decorator
----------------------------------------+-----------------------------------
          Reporter:  jsdalton           |         Owner:  nobody             
            Status:  new                |     Milestone:  1.3                
         Component:  Cache system       |       Version:  SVN                
        Resolution:                     |      Keywords:  blocker, regression
             Stage:  Ready for checkin  |     Has_patch:  1                  
        Needs_docs:  0                  |   Needs_tests:  0                  
Needs_better_patch:  0                  |  
----------------------------------------+-----------------------------------
Changes (by russellm):

  * stage:  Unreviewed => Ready for checkin

Comment:

 Ok - your test case now makes it clear that there are a couple of bugs.
 I'm marking RFC, will check in shortly with a couple of minor
 modifications.

 In particular:

  * Using try:catch logic instead of "if contains" logic is marginally
 faster, because it only requires one lookup for all cases, rather than two
 lookups on the successful lookup case.
  * The or-emulate "ternary if" is prone to error, especially in the "if x
 is None" versus "x is False" case, so we generally prefer the explicit if
 statement.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/15144#comment:5>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to