#15111: manage.py test fails if sites app not installed
----------------------------------------+-----------------------------------
          Reporter:  wkornewald         |         Owner:  nobody
            Status:  new                |     Milestone:  1.3   
         Component:  Contrib apps       |       Version:  SVN   
        Resolution:                     |      Keywords:        
             Stage:  Ready for checkin  |     Has_patch:  1     
        Needs_docs:  0                  |   Needs_tests:  0     
Needs_better_patch:  0                  |  
----------------------------------------+-----------------------------------
Comment (by wkornewald):

 Maybe if the purpose of the last line is to check if the exception is
 raised even with the Site cache filled we might need a small extra change.
 But then I'd rather extend get_current(), so it's guaranteed to raise
 Site.DoesNotExist if Site._meta.installed is False and have a unit test in
 the sites app for that.

 OTOH, I'd question the whole purpose of testing against a filled cache
 with Site._meta.installed set to False via a hack because then the unit
 test would verify if everything works correctly even if people use ugly
 hacks in their code (i.e., manipulating Site._meta.installed in production
 code).

-- 
Ticket URL: <http://code.djangoproject.com/ticket/15111#comment:2>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to