#13285: Generic views call populate_xheaders, which breaks caching
----------------------------------------+-----------------------------------
Reporter: carljm | Owner: nobody
Status: reopened | Milestone:
Component: Cache system | Version: 1.1
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 |
----------------------------------------+-----------------------------------
Comment (by carljm):
The function-based generic views are now deprecated, and the class-based
views that replaced them do not call populate_xheaders. So the only
remaining non-deprecated view in the Django source tree that calls
populate_xheaders is the flatpage view.
My take at this point is that the populate_xheaders function itself is a)
of marginal usefulness, since these sorts of debugging headers can easily
be added without a generic function for it, b) now barely used within
Django, c) breaks caching as written, and d) completely undocumented. So,
barring major objections, I think it should just be removed from Django
entirely. Since it's undocumented I don't think a deprecation path is
strictly needed, but to err on the side of caution it could be deprecated
along the same timeline as the function-based generic views, since they
all call it.
--
Ticket URL: <http://code.djangoproject.com/ticket/13285#comment:3>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
