#14705: Model Field Order not influenced by MRO of superclasses
------------------------------------------+---------------------------------
               Reporter:  vanschelven     |         Owner:  nobody
                 Status:  new             |     Milestone:  1.3   
              Component:  Core framework  |       Version:  SVN   
             Resolution:                  |      Keywords:        
           Triage Stage:  Accepted        |     Has patch:  1     
    Needs documentation:  0               |   Needs tests:  0     
Patch needs improvement:  1               |  
------------------------------------------+---------------------------------
Changes (by russellm):

  * needs_better_patch:  0 => 1
  * stage:  Ready for checkin => Accepted


Comment:

 This patch appears to be headed broadly in the right direction, and it
 works, but I'm not convinced that it's quite right yet.

 In particular, the fact that it is introducing a new `model_bases`
 attribute to the Meta class when `parents` already exists concerns me.
 Granted, the two aren't completely identical -- parents doesn't include
 any abstract classes, for example -- but it strikes me that the right
 solution here isn't just to add a new block of almost identical metadata,
 but to adjust the existing metadata, and adjust the existing usage.

 The Meta class is in bad need of some housekeeping -- I'd rather not
 knowingly add to that housekeeping work.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/14705#comment:9>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to