#11195: add fieldname to admin changelist <td> tags -- eases CSS customization
------------------------------------------------+----------------------
               Reporter:  akaihola              |        Owner:  nobody
                 Status:  new                   |    Milestone:
              Component:  django.contrib.admin  |      Version:  SVN
             Resolution:                        |     Keywords:  css
           Triage Stage:  Accepted              |    Has patch:  1
    Needs documentation:  1                     |  Needs tests:  0
Patch needs improvement:  0                     |
------------------------------------------------+----------------------
Changes (by ramiro):

 * needs_docs:  0 => 1
 * stage:  Design decision needed => Accepted


Comment:

 Replying to [comment:3 akaihola]:
 >
 > vjimw seems to have a
 [http://code.djangoproject.com/attachment/ticket/14291/admin_list.py.patch
 patch] there as well. We should take a look at it and see if he has found
 a more elegant solution or thought of corner cases I might have missed.

 vjimw's patch had no extra functionality compared to yours. Only
 difference is the class name

 I've updated the patch with:

  * Avoid touching the class of the select chebox cell, it is still
 `'action-checkbox'` instead of being renamed to
 `fieldname_action_checkbox'`.
  * Changed class name reparator from `'_'` `'-'` to be consisten with
 other CSS class names used in the same view.
  * Shortened the class name prefix from `'fieldname'` to `'fldname'`. Not
 completely happy with it, maybe we can use vjimw's approach?

-- 
Ticket URL: <http://code.djangoproject.com/ticket/11195#comment:4>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to