#10964: Admin for group doesn't allow to easily add users to the group
-------------------------------------+-------------------------------------
Reporter: gruszczy | Owner: nobody
Status: new | Milestone:
Component: | Version: SVN
django.contrib.admin | Keywords: admin, groups
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed |
Needs documentation: 0 |
Patch needs improvement: 0 |
-------------------------------------+-------------------------------------
Comment (by lukeplant):
The patch would need a lot of work before it could possibly go in. _roman
highlights one issue (the csrf_protect_m decorator is not applied). There
are lots of others, like:
* the overridden add_view and change_view remove '''lots''' of
functionality present in the base class methods, for no apparent reason.
* why not just set the `form = GroupForm` on `GroupAdmin`?
* why do we need to override the template?
* 8 spaces for indentation instead of 4.
We also have to consider the case where people have further sub-classed
`GroupAdmin`, or provided their own template - their customised admin
interfaces should not break, as far as we can ensure that.
I think that the idea in general is good. We may need to consider whether
a different approach entirely is needed - the basic problem is that while
M2Ms are (nearly) symmetrical in terms of the API that is produced by the
ORM on the two related models, irrespective of which model the M2M is
defined on, the admin responds quite differently depending on which model
has the M2M defined. This isn't ideal, as which model gets the M2M can be
determined simply by the order of dependencies and things like that.
--
Ticket URL: <http://code.djangoproject.com/ticket/10964#comment:4>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
