#14091: PATCH: fix incorrect quoting in connection.queries for MySQL
-------------------------------------+-------------------------------------
Reporter: danielr | Owner: aaugustin
Status: new | Milestone:
Component: Database | Version: 1.2
layer (models, ORM) | Keywords:
Resolution: | Has patch: 1
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* needs_tests: 1 => 0
Comment:
Attached patch implements query retrieval for MySQL and Oracle, and proper
query rebuilding for SQLite.
With this patch, the postgresql (psycopg v1) backend still does not have
proper escaping, but it is deprecated. A discussion on IRC determined that
implementing a generic (SQL-92 style) parameter escaping function would be
a bad idea, because it's extremely difficult to get right. For starters,
mapping the Python types to database parameters is database dependent...
So we will stick to database-specific implementations.
I tested the patch under SQLite and MySQL.
I do not have access to an Oracle server. My proposal is purely based on
the doc. However, the change is trivial and could easily be reverted if
the tests do not pass under Oracle.
--
Ticket URL: <http://code.djangoproject.com/ticket/14091#comment:4>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
