#15918: settings.THOUSAND_SEPARATOR is ignored on output
-------------------------------------+-------------------------------------
               Reporter:  lev        |          Owner:  nobody
                   Type:  Bug        |         Status:  closed
              Milestone:             |      Component:
                Version:  1.3        |  Internationalization
             Resolution:  invalid    |       Severity:  Normal
           Triage Stage:             |       Keywords:  THOUSAND_SEPARATOR
  Unreviewed                         |      Has patch:  1
    Needs documentation:  0          |    Needs tests:  1
Patch needs improvement:  0          |  Easy pickings:  1
-------------------------------------+-------------------------------------
Changes (by aaugustin):

 * status:  new => closed
 * needs_docs:   => 0
 * resolution:   => invalid
 * needs_tests:   => 1
 * needs_better_patch:   => 0


Comment:

 In the docstring of `django.utils.formats.get_format`, I read that the
 value from the settings is intended only for the cases where no locale is
 defined, which probably means `USE_L10N = True` and `USE_I18N = False`.

 I assume you have I18N enabled, and this is why the value from
 `settings.THOUSAND_SEPARATOR` is not used. Please provide more details and
 reopen the ticket if I have misunderstood your problem.

 The current code uses`_format_cache[cache_key] or getattr(settings,
 format_type)`, and it looks correct. `settings.<WHATEVER>` is a default
 value that will be used if no format could be found by lines 74-80, which
 leads to `_format_cache[cache_key] = None` the next time the function is
 called.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/15918#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to