#15931: Patch for admin change form to dodge multi-db bug
-------------------------------------+-------------------------------------
Reporter: dchandek | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Component: contrib.admin
Milestone: | Severity: Normal
Version: 1.3 | Keywords:
Resolution: invalid | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 1
Needs documentation: 0 |
Patch needs improvement: 0 |
-------------------------------------+-------------------------------------
Changes (by kmtracey):
* status: new => closed
* resolution: => invalid
Comment:
You seem to have ignored all of the logic in the shortcut view that
attempts to determine the correct site to redirect to, starting here:
http://code.djangoproject.com/browser/django/trunk/django/contrib/contenttypes/views.py#L28
On the face of it, then, it doesn't look to me like replacing a call to
the shortcut view with a call to get_absolute_url directly will be
equivalent in all cases. Thus attempting to dodge one bug by making this
substitution in admin code is not the right thing to do, even as a stopgap
measure: it will introduce a regression for anyone relying on that site-
choosing logic being in place. The right way to approach this is to fix
the base bug.
--
Ticket URL: <http://code.djangoproject.com/ticket/15931#comment:2>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
