#15900: reverse() does not properly escape namespaced views
------------------------------------+------------------------------
Reporter: teolicy | Owner: dmclain
Type: Bug | Status: assigned
Milestone: | Component: Core (Other)
Version: 1.3 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 | Easy pickings: 0
------------------------------------+------------------------------
Changes (by julien):
* needs_better_patch: 0 => 1
Comment:
I've had a quick look at this and I'm not sure if this patch addresses the
core issue. dmclain, you mention that the resolver did not normalise
prefixes, yet I see there already are passing tests for the following
pattern at
source:django/trunk/tests/regressiontests/urlpatterns_reverse/extra_urls.py#L12:
{{{
#!python
url(r'^prefix/(?P<prefix>\w+)/',
include('regressiontests.urlpatterns_reverse.included_urls2')),
}}}
As mentioned by the reporter, the bug only occurs when a namespace is
used, yet I fail to see how your patch specifically addresses that. Could
you elaborate on your approach?
Also, looking at your tests, the following passes:
{{{
#!python
(r'^other[246]/', include(otherobj2.urls)),
}}}
... yet the tests unexpectedly fail if I swap the digits:
{{{
#!python
(r'^other[426]/', include(otherobj2.urls)),
}}}
Finally, for completeness, it'd be good to test what is supposed to
happen, for example, with "/other9/inner/".
--
Ticket URL: <http://code.djangoproject.com/ticket/15900#comment:7>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
