#5833: Custom FilterSpecs
-------------------------------------+-------------------------------------
               Reporter:             |          Owner:  jkocherhans
  Honza_Kral                         |         Status:  assigned
                   Type:  New        |      Component:  contrib.admin
  feature                            |       Severity:  Normal
              Milestone:             |       Keywords:  nfa-someday
                Version:  SVN        |  list_filter filterspec nfa-
             Resolution:             |  changelist ep2008
           Triage Stage:  Accepted   |      Has patch:  1
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
-------------------------------------+-------------------------------------

Comment (by jezdez):

 Thanks everyone for the work on this patch, I've just reviewed it and took
 the liberty to modify the API a bit more:

 - Reverted the Java-esque `SingleQueryParameterListFilter` to
 `SimpleListFilter` again, which has a `lookups` (instead of `get_choices`)
 method as the only difference to the other filter classes.
 - Renamed `get_output_choices` to `choices` since it really is the best
 description for its functionality
 - Cleaned up some unneeded implementation details (e.g.
 `ChangeList.apply_list_filters`)
 - Stopped slugifying the title for the parameter name since it'll most
 likely be a `ugettext_lazy` variable. Instead the `parameter_name` is now
 a required class attribute like the title.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:124>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to