#8999: ModelAdmin.get_form and get_formset will overwrite self.exclude with a
kwargs exclude
-------------------------------------+-------------------------------------
Reporter: seanl | Owner: jkocherhans
Type: | Status: assigned
Cleanup/optimization | Component: contrib.admin
Milestone: | Severity: Normal
Version: 1.0 | Keywords:
Resolution: | Has patch: 1
Triage Stage: Ready for | Needs tests: 0
checkin | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
-------------------------------------+-------------------------------------
Comment (by julien):
Thanks Jannis. I don't think it needs a release note. The removed lines
were actually useless. If `exclude` is passed via `get_form()`'s kwargs,
then it is first combined to `ModelAdmin.exclude` but a bit further it
overrides it anyway via `defaults.update(kwargs)`.
The provided tests verify the current behaviour and they pass whether
those two lines are present or not. This is basically just cleaning up
some stale code. No one could have possibly relied on a different
behaviour.
--
Ticket URL: <https://code.djangoproject.com/ticket/8999#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
