#16202: Localflavor support for Slovenia (si) -------------------------------------+------------------------------------- Reporter: Jure | Owner: nobody Cuhalev <gandalf@…> | Status: new Type: New | Component: contrib.localflavor feature | Severity: Normal Milestone: | Keywords: Version: 1.3 | Has patch: 1 Resolution: | Needs tests: 0 Triage Stage: Ready for | Easy pickings: 0 checkin | Needs documentation: 0 | Patch needs improvement: 0 | UI/UX: 0 | -------------------------------------+------------------------------------- Changes (by vasiliyeah):
* stage: Accepted => Ready for checkin Comment: Replying to [comment:8 iElectric]: > Replying to [comment:7 anonymous]: > > * Regarding the birth year, I'd just asume <2000 if it's 800 or higher just to be safe. > > Even the oldest person still alive is not old enough, should be safe. If you insist, we can change it to 800. > > > * Regarding validating that because of wrong birth date in the UMCN - these cases were rare and as I understand they were just one or two days off. I haven't heard of a case where someone was given a UMCN with a date years in the future. > > Roger. > > Your implementation works fine with 10k examples including what they give here to foreign nationals. Info gets extracted fine. > > One more thing I would suggest is applying ugettext_lazy to the regions/cities names in SI_POSTALCODES. That way if a region has a different name in English or German for example a user using a localized version of the site can see the appropriate names in their locale in the ChoiceField. > Posts are not translated to any other language, I would say i18n them is redundant. Maybe. That's up to you. Patch applies and all tests run fine. -- Ticket URL: <https://code.djangoproject.com/ticket/16202#comment:9> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.