#16361: IGNORABLE_404 functionality should respect APPEND_SLASH setting
------------------------------------+-------------------------------
Reporter: Leo | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Documentation
Version: 1.3 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------+-------------------------------
Comment (by lukeplant):
Replying to [comment:4 anonymous]:
> Why not do a re.sub()?
>
> https://code.djangoproject.com/changeset/16160#file1
>
> return any(pattern.search(re.sub("/$", "", uri)) for pattern in
settings.IGNORABLE_404_URLS)
The solution is not as simple as that for the case where the pattern
actually includes the trailing slash - I don't think you can avoid running
over the patterns twice for the case where APPEND_SLASH = True.
In addition, the question is, do we want the trailing slash to be ignored
because it **might** have been added due to `CommonMiddleware` and
APPEND_SLASH? We don't know that it **has** been added by
`CommonMiddleware`. Since it is generally more powerful left as it is, I
think we should just add a note to the docs.
--
Ticket URL: <https://code.djangoproject.com/ticket/16361#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
