#16504: PROJECT_ROOT ought to be in the generated project settings module
-------------------------------------+-------------------------------------
               Reporter:  pydanny    |          Owner:  rvanhoepen
                   Type:  New        |         Status:  assigned
  feature                            |      Component:  Core (Other)
              Milestone:  1.4        |       Severity:  Normal
                Version:  1.3        |       Keywords:
             Resolution:             |      Has patch:  1
           Triage Stage:  Design     |    Needs tests:  1
  decision needed                    |  Easy pickings:  0
    Needs documentation:  1          |
Patch needs improvement:  1          |
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
Changes (by aaugustin):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Design decision needed


Comment:

 Sorry to slow down your enthusiasm, but:
 - design decision needed means a core developer must accept or reject the
 idea; only a core developer can move a ticket from DDN to Accepted,
 - the patch must be reviewed by someone else before it can be marked as
 ready for checkin,
 - the patch can't be ready for checkin if it needs docs and tests.

 See https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
 tickets/ for more information about this process.

 Regarding the patch itself:
 - You inserted an import between a comment and the line that is commented,
 so the comment no longer makes sense,
 - I don't understand why you set `PROJECT_PATH` to `django/conf` by
 default.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/16504#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to