#13896: Change language to dynamic attribute in syndication feed generator
-------------------------------------+-------------------------------------
Reporter: jedie | Owner: jasonkotenko
Type: New | Status: assigned
feature | Component: contrib.syndication
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 1 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by julien):
* needs_better_patch: 0 => 1
* ui_ux: => 0
Comment:
The patch looks pretty good but there is one slight inconsistency. The doc
says:
{{{
You can set the language for a feed by specifying an attribute
:attr:`language`, using the ***same format*** as the project-wide setting
:setting:`LANGUAGE_CODE`.
}}}
... yet the code is:
{{{#!python
language = self.__get_dynamic_attr('language', obj,
settings.LANGUAGE_CODE.decode()),
}}}
So the `LANGUAGE_CODE` setting is decoded whereas the `language` API
attribute isn't. Ideally the behaviour should be normalised and made
consistent.
--
Ticket URL: <https://code.djangoproject.com/ticket/13896#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
