#15316: Filter with isnull=False failing when isnull checked on subclass of FK
model
-------------------------------------+-------------------------------------
Reporter: zimnyx | Owner: ethlinn
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: SVN | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords:
Needs documentation: 0 | Has patch: 1
Patch needs improvement: 1 | Needs tests: 1
UI/UX: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Comment (by ethlinn):
I changed the patch. Instead of promoting the join I added extra parameter
(isnull_skip) which if set to True breaks while loop in trim_joins
function. Not sure if it should launch trim_join() at all in case
isnull=False. Maybe it's easier just to set values of col and alias in
add_filter() in this case (I'll look at this possibility tomorrow). I also
added tests for OneToOneField instead of inheritance (just in case).
--
Ticket URL: <https://code.djangoproject.com/ticket/15316#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
