#16705: r13746 makes invalid assumption that QUERY_STRING exists
------------------------------------+---------------------------------
Reporter: raylu | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Generic views
Version: SVN | Severity: Release blocker
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 1
Patch needs improvement: 1 | Easy pickings: 1
UI/UX: 0 |
------------------------------------+---------------------------------
Comment (by russellm):
@raylu -- Your claim is demonstrably false. If it were true, there would
be a failing case in the test suite.
The case of query_string=True and query_string=False may be tested; but
the non-existence of QUERY_STRING in the WSGI environment *isn't* tested,
because the Django test client sets QUERY_STRING by default. We need a
test that demonstrates that if QUERY_STRING *isn't* in the environment,
the current code fails, but your patch makes the test pass.
--
Ticket URL: <https://code.djangoproject.com/ticket/16705#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
