Author: mtredinnick
Date: 2011-08-25 22:28:58 -0700 (Thu, 25 Aug 2011)
New Revision: 16691
Modified:
django/trunk/docs/internals/contributing/writing-code/coding-style.txt
Log:
Add a note about discouraging whitespace- or formatting-only patches.
We follow the python-dev path here. Deliberately.
Modified: django/trunk/docs/internals/contributing/writing-code/coding-style.txt
===================================================================
--- django/trunk/docs/internals/contributing/writing-code/coding-style.txt
2011-08-26 04:36:31 UTC (rev 16690)
+++ django/trunk/docs/internals/contributing/writing-code/coding-style.txt
2011-08-26 05:28:58 UTC (rev 16691)
@@ -188,7 +188,10 @@
add unnecessary bytes, add visual clutter to the patches and can also
occasionally cause unnecessary merge conflicts. Some IDE's can be
configured to automatically remove them and most VCS tools can be set to
- highlight them in diff outputs.
+ highlight them in diff outputs. Note, however, that patches which only
+ remove whitespace (or only make changes for nominal PEP 8 conformance)
+ are likely to be rejected, since they only introduce noise rather than
+ code improvement. Tidy up when you're next changing code in the area.
* Please don't put your name in the code you contribute. Our policy is to
keep contributors' names in the ``AUTHORS`` file distributed with Django
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
