#16568: require_debug_false does not work as intended (backward incompatible)
-----------------------------------------+---------------------------------
Reporter: andreas_pelme | Owner: nobody
Type: Bug | Status: new
Milestone: 1.4 | Component: Core (Other)
Version: SVN | Severity: Release blocker
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+---------------------------------
Comment (by carljm):
Just spent a while trying to write a proper end-to-end regression test for
this failure case, and there really is no reliable way to do it, since we
can't enforce that tests are run with no LOGGING setting. We'd need to
able to save-modify-and-restore the entire global state of the logging
module, which AFAICT there is no way to do.
The `test_require_debug_no_logging_setting` test in the patch does test
the added `RequireDebugFalse` filter, but the `setUp` and `tearDown`
methods in that test case are pointless: temporarily overriding
settings.LOGGING has no impact, because the setting will already long ago
have been parsed and passed to logging.dictConfig.
So I think we'll have to be satisfied with testing the filter and testing
that `global_settings.LOGGING` has that filter in the config. This should
be adequate.
--
Ticket URL: <https://code.djangoproject.com/ticket/16568#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
