#16837: when logging in into the admin
-------------------------------------+-------------------------------------
Reporter: Wim | Owner: nobody
Feijen <wim@…> | Status: new
Type: Bug | Component: contrib.admin
Milestone: | Severity: Normal
Version: 1.3 | Keywords:
Resolution: | Has patch: 1
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 1
Patch needs improvement: 1 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by julien):
* needs_tests: 1 => 0
Comment:
Thank you Wim, the message looks good. However, the tests aren't proper.
If `ERROR_MESSAGE` accidentally gets modified to, for example, "I love
double rainbows", the tests will still pass :D
The message may have serious security implications so it's important to
explicitly test it.
Also, one note on the process. When you provide a patch that *you* think
is right, please feel free to remove the "Needs tests" and "Patch needs
improvement" flags, so that the ticket can more easily be found by people
looking for patches to review. In this case, I'm removing "Needs tests"
because there are some, but leaving "Patch needs improvement" because it
does ;)
--
Ticket URL: <https://code.djangoproject.com/ticket/16837#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
