#16925: disconnect signal before checking test success
------------------------------------+--------------------------
               Reporter:  adsworth  |          Owner:  adsworth
                   Type:  Bug       |         Status:  new
              Milestone:            |      Component:  Python 3
                Version:  1.3       |       Severity:  Normal
             Resolution:            |       Keywords:
           Triage Stage:  Accepted  |      Has patch:  1
    Needs documentation:  0         |    Needs tests:  0
Patch needs improvement:  0         |  Easy pickings:  0
                  UI/UX:  0         |
------------------------------------+--------------------------
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 The best best way to ensure the signal gets disconnected is to use a try /
 finally. See attached patch.

 I'm not sure how to run the tests under Python 3 — I checked out the py3k
 branch, but runtests.py fails with this error:
 {{{
   File "runtests.py", line 118
     print "Importing application %s" % module_name
                                    ^
 SyntaxError: invalid syntax
 }}}

 If the new patch works for you, feel free to mark the ticket as RFC.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/16925#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to