#16187: Refactor lookup system
-------------------------------------+-------------------------------------
Reporter: UloPe | Owner: UloPe
Type: | Status: new
Cleanup/optimization | Version: 1.3
Component: Database layer | Resolution:
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by akaariai):
Not this ticket's problem, but it would make sense to do even bigger
refactor in the direction that first do a traversal of the lookup path and
determine if there are multi-joins in the path, raise errors if the path
is not valid etc, and only after that do setup_joins with the valid path.
This ticket's patch is one step in that direction, because this already
traverses the lookup path upfront. The next step would be to check errors
already at this point and use the info gathered during the traversal for
setup_joins calls.
That being said, I will try to review (as in point out what needs
improvement in my opinion) tomorrow.
--
Ticket URL: <https://code.djangoproject.com/ticket/16187#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
