#11670: Minor limitation using fields named 'year' in related searches.
-------------------------------------+-------------------------------------
Reporter: andy@… | Owner:
Type: Bug | Status: new
Component: Database layer | Version: SVN
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by akaariai):
* cc: anssi.kaariainen@… (added)
Comment:
I read somewhat quickly through the patch. This looks simple and
efficient.
I think this could be extended in the future if need be (referring for
example to ticket #16187).
However, I wonder if it would be better to make this a separate method.
This could be usable in checking the validitity of other calls, order_by
for example. I would actually go so far as to make this model._meta
method, returning 3-tuple field_path, final_field (which can be in
field_path or not), and lookup_parts. This could be useful outside of
sql.query, and this would make for proper separation of concerns.
I don't have time for more thorough review at the moment. I am not
changing patch needs improvement. I wonder if it is set for the latest
patch or just forgotten to checked?
--
Ticket URL: <https://code.djangoproject.com/ticket/11670#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
