#16715: Wrong JOIN with nested null-able foreign keys
-------------------------------------+-------------------------------------
     Reporter:  sebastian            |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  SVN
  (models, ORM)                      |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:  join, values,        |      Needs documentation:  0
  nested, foreign key, null-able     |  Patch needs improvement:  0
    Has patch:  1                    |                    UI/UX:  0
  Needs tests:  0                    |
Easy pickings:  0                    |
-------------------------------------+-------------------------------------

Comment (by sebastian):

 So, what should be our next step? How do we get your patch reviewed and
 maybe approved of by another developer, or even one of the core
 developers? Making more fundamental changes to how queries are generated
 (as hinted at by you) doesn't seem a likely approach at the moment since
 it suggests a lot of work, essentially rewriting the entire query
 generator.

 (However, I think that changing the way queries are generated as you
 suggested is something that should be kept in mind. It seems to be the
 Right Way of doing things, and it also seems to simplify a lot of code (I
 guess) by not having to keep track of all the resulting joins at all times
 but rather track only the ''properties'' of joins, determining the
 required join type only in the end.)

 In the meantime, your patch certainly fixes the problem of picking the
 wrong join in the scope of this ticket. So how do we proceed?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/16715#comment:17>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to