#17016: File uploading documentation leaves out the easiest method for saving a
file with a model
-------------------------------+------------------------------------
Reporter: tim.saylor@… | Owner: nobody
Type: New feature | Status: new
Component: Documentation | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by aaugustin):
* needs_docs: => 0
* needs_better_patch: => 1
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
The patch looks good overall, but I have a few suggestions:
- We should mention `ModelForm`s first, because they're really the easiest
way to save files from a form into a model.
- The key information of this paragraph is this line:
`ModelWithFileField(file_field=request.FILES['file'])`. However, you patch
talks a lot about `upload_to` and that blurs a bit the message.
`upload_to` is documented in the fields API under `FileField`; in my
opinion it isn't necessary to duplicate the information here.
- there's a small typo : req**eu**st.FILES
- AUTHORS is sorted alphabetically by last name, first name.
--
Ticket URL: <https://code.djangoproject.com/ticket/17016#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
