#14806: No template tag to support contextual translations
--------------------------------------+------------------------------------
Reporter: jtiai | Owner: julien
Type: New feature | Status: new
Component: Internationalization | Version: SVN
Severity: Normal | Resolution:
Keywords: i18n | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by aaugustin):
The patch looks very good and the documentation is clear.
I have only one question: shouldn't this example read `context "greeting"`
rather than `context="greeting"`? It looks inconsistent with the docstring
of `do_block_translate` and the regexps.
{{{
{% blocktrans with name=user.username context="greeting" %}Hi {{ name }}{%
endblocktrans %}
}}}
----
Unfortunately, I couldn't apply the patch to my checkout, even with `git
apply`:
{{{
error: cannot apply binary patch to
'tests/regressiontests/i18n/other/locale/de/LC_MESSAGES/django.mo' without
full index line
error: tests/regressiontests/i18n/other/locale/de/LC_MESSAGES/django.mo:
patch does not apply
}}}
As a consequence, my review is based on code inspection. I didn't run the
tests, but they look solid.
--
Ticket URL: <https://code.djangoproject.com/ticket/14806#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
