#17067: REMOTE_ADDR should be set to 127.0.0.1 in the test client environment
-----------------------------------+------------------------------------
Reporter: jsdalton | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: 1.3
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by aaugustin):
* type: Uncategorized => Bug
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
Comment:
Indeed, it's a regression => release blocker.
The root of the problem is that #8551 and #16705 have been resolved with
different mindsets: "do something reasonable for most cases" vs. "follow
the reference documentation strictly".
----
I'd prefer following a solid reference before adding / removing more
variables to / from the default environment of the test client. However, I
didn't find a good one.
The current reference is PEP 3333; I admit it isn't totally realistic.
Looking at RFC 3875 (CGI 1.1, http://www.ietf.org/rfc/rfc3875), most of
the meta-variables defined there are irrelevant, so it isn't a good
starting point either.
Thus, I think that the best fix is to put back REMOTE_ADDR in the default
environment, with a comment saying "not defined by PEP 3333, but provided
by most webservers, see #8551"
--
Ticket URL: <https://code.djangoproject.com/ticket/17067#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
