#10046: ModPythonHandler class should check for IOError when writing response
-------------------------------------+-------------------------------------
Reporter: ewoudenberg | Owner: nobody
Type: Bug | Status: closed
Component: HTTP handling | Version: 1.1
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by carljm):
Since this can occur under `mod_wsgi` as well as `mod_python`, the
original reason for a wontfix (deprecation of `mod_python` handler) does
not apply. (I now see that `mod_wsgi` was mentioned earlier in the thread,
sorry I missed that the first time around.)
However, after discussion with grahamd (author of `mod_wsgi`) on IRC, we
are in agreement that the proposed fix here (catching `IOError` in
Django's handler) is not appropriate, and could mask other, more serious,
errors (and that users should have the choice of whether the error
described here is "interesting" to them, Django should not make a
unilateral decision that it is not). In other words, this is not an issue
in Django's `WSGIHandler`, the correct fix is for users to filter error
reporting in order to not email errors that are uninteresting to them.
Thus the wontfix still stands.
Since Django's admin error emails are now handled by the Python stdlib
logging module, filtering them is rather easy - just a matter of defining
a custom logging Filter and including it in your logging config. This can
be done today and doesn't require any code changes to Django. We could add
a documentation example of doing this; that's tracked by #17069.
--
Ticket URL: <https://code.djangoproject.com/ticket/10046#comment:20>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
