#17318: 'Topic authentication', section 'Storing additional information about
users' there is bug in the code
---------------------------------+--------------------------------------
     Reporter:  supreet.sethi@…  |                    Owner:  nobody
         Type:  Bug              |                   Status:  closed
    Component:  Documentation    |                  Version:  1.3
     Severity:  Normal           |               Resolution:  invalid
     Keywords:  UserProfile      |             Triage Stage:  Unreviewed
    Has patch:  0                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+--------------------------------------
Changes (by kmtracey):

 * status:  new => closed
 * needs_better_patch:   => 0
 * resolution:   => invalid
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 The proposed change is unnecessary (create() already saves the new object
 to the DB) and would not do anything to fix an !IntegrityError. You'd get
 an !IntegrityError if somehow this `create_user_profile` was called with
 `create` set to `True` for some user instance where there was already a
 `UserProfile` object for it in the DB. I'm not sure how that would have
 happened, but tacking `.save()` onto that existing line of code wouldn't
 fix that problem.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/17318#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to