#2879: Add live test server support to test framework
-------------------------------------+-------------------------------------
Reporter: Mikeal Rogers | Owner: devin
<mikeal@…> | Status: new
Type: New feature | Version:
Component: Testing framework | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by akaariai):
Still a couple of minor things.
If I am not mistaken this part of admin_login will not work in i18n
setting: It is not "Log in" in Finnish :)
{{{
self.selenium.find_element_by_xpath('//input[@value="Log in"]').click()
}}}
The same language-dependency is also visible in the admin_inlines tests.
These can probably be fixed later on.
A small nitpick: some method docstrings are written as:
{{{
"""Comment begins here
...
"""
}}}
whereas I believe the recommended style is:
{{{
"""
Comment begins on separate line...
"""
}}}
Last nitpick is the handling of exceptions in `LiveServerThread`.run().
You fixed the exception from missing STATIC_URL, but I think it would be
good to have
{{{
except Exception, e:
self.e = e
self.is_ready.set()
raise
}}}
in the end of the run method, below the except `WSGIServerException`. It
is unlikely the general "except Exception:" is ever hit, but if it is for
some reason (out of memory or something...) this will prevent lockup.
As said, just minor nitpicks. I haven't fully tested the latest patch, but
I think it is possible to commit this as is, and then fix the issues once
this is committed.
--
Ticket URL: <https://code.djangoproject.com/ticket/2879#comment:98>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
